[Asterisk-code-review] res_pjsip_logger: Add method-based logging option. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Alexei Gradinari.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18824 )

Change subject: res_pjsip_logger: Add method-based logging option.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

File doc/CHANGES-staging/res_pjsip_logger_method.txt:

https://gerrit.asterisk.org/c/asterisk/+/18824/comment/1ba2f8b9_0c6064e0 
PS2, Line 3: SIP messages can now be filtered by SIP method,
Same comment as in the code itself, this isn't clear enough about what filtering by SIP method actually means.


File res/res_pjsip_logger.c:

https://gerrit.asterisk.org/c/asterisk/+/18824/comment/ecca6020_42a23b38 
PS2, Line 340: 	if (!pjsip_log_test_addr(default_logger, tdata->tp_info.dst_name, tdata->tp_info.dst_port, &tdata->msg->line.req.method)) {
This doesn't work for responses, and the documentation does not make it explicitly clear that this is only for SIP requests.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18824
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Idd03bd9b466b40e4bca7769437d52ac13a957cf9
Gerrit-Change-Number: 18824
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 10:41:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220816/2a929bb3/attachment.html>