[Asterisk-code-review] res_musiconhold: Add option to not play music on hold on unanswered c... (asterisk[master])

[N A]

Attention is currently required from: sungtae kim.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18966 )

Change subject: res_musiconhold: Add option to not play music on hold on unanswered channels
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
I'm kind of curious what the use case is here... Disabling all MOH globally for unanswered calls could be a major degradation. It might be desirable to do this on a per-channel or per-class basis instead. A lot of applications have an option to skip execution if the channel has not been answered, and I'm wondering if a way to do it like that might be more appropriate... though I can't think of an elegant way to do it off the top of my head so this is probably better than nothing.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18966
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1ab0defa43a29a26ae39f94c623596cf90fddc08
Gerrit-Change-Number: 18966
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Sat, 13 Aug 2022 22:09:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220813/a069ce39/attachment.html>