[Asterisk-code-review] testsuite: Python3 (testsuite[16])

Michael Bradeen asteriskteam at digium.com
Thu Aug 11 13:05:06 CDT 2022


Michael Bradeen has uploaded this change for review. ( https://gerrit.asterisk.org/c/testsuite/+/18964 )


Change subject: testsuite: Python3
......................................................................

testsuite: Python3

Multiple changes for compatibility.  Assumes use of 1.1 brnach of
starpy and the python3 branch of yappcap.

Asterisk must also be updated to use new virtual environment

Changes also to print, replaced old library references, broke up
sub-parameters, etc.

Twisted input to realtime is bytes, while internally strings are used
so multiple changes required in order to convert back and forth.

rest_api multiple removals of xrange in favor of range and making
sure that all calls to write to stdout are in byte format.

rls required a change to use BytiesIO and a bytestring.

pjsua_mod removed, replaced with extension bank and sipp

chan sip tests using the pjsua app all needed a flush after writing
to stdin

Current failing tests marked with: "skip: 'Python3-issues'"

ASTERISK-26826

Change-Id: I28a00992e54f8515fef15f77b877e2dff7767830
---
M lib/python/asterisk/asterisk.py
1 file changed, 4 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/64/18964/1

diff --git a/lib/python/asterisk/asterisk.py b/lib/python/asterisk/asterisk.py
index ff96dad..1f049fd 100644
--- a/lib/python/asterisk/asterisk.py
+++ b/lib/python/asterisk/asterisk.py
@@ -465,7 +465,7 @@
                                                 cmd[0],
                                                 cmd, env=os.environ)
             # Begin the wait fully booted cycle
-            reactor.callLater(1, __execute_wait_fully_booted)
+            reactor.callLater(2, __execute_wait_fully_booted)
 
         def __execute_wait_fully_booted():
             """Send the CLI command waitfullybooted"""
@@ -496,8 +496,9 @@
                 LOGGER.error(msg)
                 self._start_deferred.errback(Exception(msg))
             else:
-                msg = "Asterisk core waitfullybooted failed, attempting again"
-                LOGGER.debug(msg)
+                LOGGER.debug("Asterisk core waitfullybooted failed " +
+                             "with output '%s', attempting again..." %
+                             cli_command.value.err.decode('utf-8'))
                 reactor.callLater(1, __execute_wait_fully_booted)
             return cli_command
 

-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18964
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I28a00992e54f8515fef15f77b877e2dff7767830
Gerrit-Change-Number: 18964
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-MessageType: newchange
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220811/a974804b/attachment.html>


More information about the asterisk-code-review mailing list