[Asterisk-code-review] res_geolocation: Address user issues, remove complexity, plug leaks (asterisk[16])

George Joseph asteriskteam at digium.com
Wed Aug 10 12:48:59 CDT 2022


Attention is currently required from: Joshua Colp, Benjamin Keith Ford.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18896 )

Change subject: res_geolocation: Address user issues, remove complexity, plug leaks
......................................................................


Patch Set 7:

(1 comment)

File res/res_geolocation/geoloc_eprofile.c:

https://gerrit.asterisk.org/c/asterisk/+/18896/comment/3c26f190_1011a2f4 
PS6, Line 530: 	const char *method_str;
> method_str and note_well_str are being freed further down
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18896
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If38c23f26228e96165be161c2f5e849cb8e16fa0
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 7
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Benjamin Keith Ford <bford at digium.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 17:48:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220810/a66a2d18/attachment.html>


More information about the asterisk-code-review mailing list