[Asterisk-code-review] res_geolocation: Address user issues, remove complexity, plug leaks (asterisk[16])

Benjamin Keith Ford asteriskteam at digium.com
Wed Aug 10 10:52:55 CDT 2022


Attention is currently required from: George Joseph.
Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18896 )

Change subject: res_geolocation: Address user issues, remove complexity, plug leaks
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

Patchset:

PS3: 
Red space, but not a big deal


File configs/samples/geolocation.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18896/comment/96a67bb0_e0d7664b 
PS3, Line 153: location_info = A1="New York", A3="New York", A4=Manhattan  
             : location_info = HNO=1633, PRD=W, RD=46th, STS=Street  
red space



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18896
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If38c23f26228e96165be161c2f5e849cb8e16fa0
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 3
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 15:52:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220810/ecb0f09f/attachment.html>


More information about the asterisk-code-review mailing list