[Asterisk-code-review] res_geolocation: Address user issues, remove complexity, plug leaks (asterisk[16])

[George Joseph]

Attention is currently required from: Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18896 )

Change subject: res_geolocation: Address user issues, remove complexity, plug leaks
......................................................................


Patch Set 2:

(1 comment)

File res/res_geolocation/geoloc_eprofile.c:

https://gerrit.asterisk.org/c/asterisk/+/18896/comment/edc9b756_65a4191b 
PS1, Line 525: 	const char *id = NULL;
> Since there's documentation about not needing to free ast_xml_node, it may be prudent to document here that these ones DO need to be freed accordingly.

Good point



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18896
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If38c23f26228e96165be161c2f5e849cb8e16fa0
Gerrit-Change-Number: 18896
Gerrit-PatchSet: 2
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-CC: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 10 Aug 2022 14:03:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220810/f51058da/attachment.html>