[Asterisk-code-review] res_pjsip: Add mediasec capabilities (asterisk[16])

[Maximilian Fridrich]

Attention is currently required from: N A, Joshua Colp.
Maximilian Fridrich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18837 )

Change subject: res_pjsip: Add mediasec capabilities
......................................................................


Patch Set 3:

(11 comments)

Patchset:

PS3: 
I have tried my best to incorporate the remarks and I have added a PR to the testsuite repo which adds test cases for this feature.


File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/e1fc822b_ae9e91cb 
PS1, Line 315: 	SORCERY_OBJECT(details);
> This doesn't need to be a sorcery object.
Done


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/e4d96b0a_639514d0 
PS1, Line 397: 	/*! The security mechanism list of the contact (RFC 3329). */
> Comment how this is dynamic and can change.
Done


File res/res_pjsip/security_agreements.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/36dd1a38_a4d9b4d5 
PS1, Line 241: 			
> Trailing whitespace
Done


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/b3788640_fa78c9a8 
PS1, Line 291: }
> Missing newline at EOF
Done


File res/res_pjsip_outbound_registration.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/8b400ace_bb646d0b 
PS1, Line 1038: 			if ((reg = ast_sorcery_retrieve_by_id(ast_sip_get_sorcery(), "registration", response->client_state->registration_name)) &&
> This introduces a TON of queries including on cases where this is not applicable. This concerns me. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/630efa4e_f82941a1 
PS1, Line 1043: 				contact_status = ast_sip_get_contact_status(contact);
> All of these objects appear to be leaked.
Done


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/b207163a_9f7aa3ee 
PS1, Line 1052: 					
> Trailing whitespace
Done


File res/res_pjsip_rfc3329.c:

https://gerrit.asterisk.org/c/asterisk/+/18837/comment/46d7733a_fa853821 
PS1, Line 49: 		contact_status = ast_sip_get_contact_status(session->contact);
> contact_status is leaked
Done


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/1fcf74a3_e4d1b0e2 
PS1, Line 53: 	if (AST_VECTOR_SIZE(&session->server_security_mechanisms) && contact_has_mechanisms) {
> This is not thread safe. Two threads could be operating on contact_status at the same time.
Done


https://gerrit.asterisk.org/c/asterisk/+/18837/comment/7870c87f_fd545a0d 
PS1, Line 86: 	contact_status = ast_sip_get_contact_status(session->contact);
> contact_status is leaked
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18837
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia7f5b5ba42db18074fdd5428c4e1838728586be2
Gerrit-Change-Number: 18837
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 16:24:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220809/1a68e19c/attachment-0001.html>