[Asterisk-code-review] res_pjsip: Add TEL URI support for basic calls. (asterisk[16])

[Benjamin Keith Ford]

Attention is currently required from: Alexei Gradinari.
Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18892 )

Change subject: res_pjsip: Add TEL URI support for basic calls.
......................................................................


Patch Set 2:

(2 comments)

File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/c/asterisk/+/18892/comment/75d1ac72_5731329c 
PS1, Line 3033: 	if (!PJSIP_URI_SCHEME_IS_SIP(request_uri) && !PJSIP_URI_SCHEME_IS_SIPS(request_uri)) {
> Ah yeah, that can be used here. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18892/comment/bc5e02d3_6dcef7a9 
PS1, Line 3266: 	if (!PJSIP_URI_SCHEME_IS_SIP(request_uri) && !PJSIP_URI_SCHEME_IS_SIPS(request_uri)) {
> why don't use ast_sip_is_allowed_uri?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18892
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If5729e6cd583be7acf666373bf9f1b9d653ec29a
Gerrit-Change-Number: 18892
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 15:20:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Comment-In-Reply-To: Benjamin Keith Ford <bford at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220809/4018424c/attachment.html>