[Asterisk-code-review] res_pjsip: Add TEL URI support for basic calls. (asterisk[16])

[Benjamin Keith Ford]

Attention is currently required from: Alexei Gradinari.
Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18892 )

Change subject: res_pjsip: Add TEL URI support for basic calls.
......................................................................


Patch Set 1:

(1 comment)

File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/c/asterisk/+/18892/comment/014c6cec_9b3a49e8 
PS1, Line 3033: 	if (!PJSIP_URI_SCHEME_IS_SIP(request_uri) && !PJSIP_URI_SCHEME_IS_SIPS(request_uri)) {
> why don't use ast_sip_is_allowed_uri?
We've decided to only make changes for basic calls at the moment due to the reports of tel URI usage being primarily limited to providers, which would not use pubsub. Some areas have been prepped for it, but this still needs to be SIP or SIPS for now. There are some parts of the code that have pjsip_sip_uri as the data type (functions and even structs) that makes it very difficult to make changes without having to break the API. It's not completely out of the question though, and if someone in the community gets around to it before we do, that's fine as well!



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18892
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If5729e6cd583be7acf666373bf9f1b9d653ec29a
Gerrit-Change-Number: 18892
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Tue, 09 Aug 2022 13:05:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220809/e4abbf2c/attachment.html>