[Asterisk-code-review] func_channel: Added new OTHER_CHANNEL function (asterisk[master])

N A asteriskteam at digium.com
Sat Aug 6 15:33:50 CDT 2022


Attention is currently required from: Joshua Colp, Mark Murawski.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/15893 )

Change subject: func_channel: Added new OTHER_CHANNEL function
......................................................................


Patch Set 7:

(1 comment)

Patchset:

PS7: 
> Another item, is consistency. […]
I agree, I think EXPORT would be a better name.
I think the parameter order might also be reserved.

The following test seems to indicate this is perfectly all right:

Before:  /1 

After:  /34

exten => s,1,Set(a=PJSIP/abc-00000000)
	same => n,Set(b=Local/s at t-00000004\;2)
	same => n,NoOp(${IMPORT(${a},test)} /${IMPORT(${b},test)} )
	same => n,Set(OTHER_CHANNEL(OTHER_CHANNEL(test,${b}),${a})=34)
	same => n,NoOp(${IMPORT(${a},test)} /${IMPORT(${b},test)} )
	same => n,Wait(2)
	same => n,Hangup()



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/15893
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7492645ae4307553d0f586d78e13a4f586231fdf
Gerrit-Change-Number: 15893
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Sat, 06 Aug 2022 20:33:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Mark Murawski <markm at intellasoft.net>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220806/19302ddb/attachment.html>


More information about the asterisk-code-review mailing list