[Asterisk-code-review] general: Very minor coding guideline fixes. (asterisk[master])

N A asteriskteam at digium.com
Sat Aug 6 14:14:23 CDT 2022


Attention is currently required from: Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18885 )

Change subject: general: Very minor coding guideline fixes.
......................................................................


Patch Set 4:

(2 comments)

File channels/iax2/include/iax2.h:

https://gerrit.asterisk.org/c/asterisk/+/18885/comment/56b41322_9d5f19a3 
PS2, Line 131: #define IAX_IE_CALLED_NUMBER			1		/*!< Number/extension being called - string */
> Tabs after the first non-whitespace will ALWAYS be an issue because of the disagreement of how to ex […]
My tab widths have always been 4 spaces and for some reason, everything outside of Gerrit has shown this issue.

I don't want to open a can of worms, so I'm tossing the alignment changes from the review. The coding guideline violations remain.


File main/strings.c:

https://gerrit.asterisk.org/c/asterisk/+/18885/comment/9bb60643_983f6179 
PS2, Line 200: //struct ao2_container *ast_str_container_alloc_options(enum ao2_container_opts opts, int buckets)
> The same comment is in the strings.h header.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18885
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I07771c4c89facd41ce8d323859f022ddbddf6ca7
Gerrit-Change-Number: 18885
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sat, 06 Aug 2022 19:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220806/ef80f632/attachment.html>


More information about the asterisk-code-review mailing list