[Asterisk-code-review] features: Add transfer initiation options. (asterisk[master])

[N A]

Attention is currently required from: Kevin Harwell, Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18001 )

Change subject: features: Add transfer initiation options.
......................................................................


Patch Set 6:

(4 comments)

File main/bridge_basic.c:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/c774ad6e_ff4e7bfc 
PS5, Line 1476: 	ast_string_field_set(props, exten, get_transfer_exten(transferer, NULL));
> Do you really need to set prop->exten here? It appears to be overwritten not long after this. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18001/comment/6e945574_7cc3f11f 
PS5, Line 3189: 	if (!ast_strlen_zero(extenoverride)) {
> Option 1: I believe you can just call extenoverride = get_transfer_exten(chan, exten) here without h […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18001/comment/8161425a_39c1c3c8 
PS5, Line 3386: 	if (grab_transfer(bridge_channel->chan, exten, sizeof(exten), props->context, props->exten)) {
> Option 2: I _think_ you can just pass result of get_transfer_exten here vs setting it on props.
Ack


https://gerrit.asterisk.org/c/asterisk/+/18001/comment/c5e60173_0d4f064b 
PS5, Line 3400: 	ast_string_field_set(props, exten, exten);
> Overwritten here after being set in attended_transfer_properties_alloc
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18001
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibff309caa459a2b958706f2ed0ca393b1ef502e3
Gerrit-Change-Number: 18001
Gerrit-PatchSet: 6
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sat, 06 Aug 2022 19:06:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <default.enum at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220806/d6a590df/attachment-0001.html>