[Asterisk-code-review] cdr: Allow bridging and dial state changes to be ignored. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18603 )

Change subject: cdr: Allow bridging and dial state changes to be ignored.
......................................................................


Patch Set 4:

(2 comments)

Patchset:

PS3: 
> Since these options also fundamentally alter CDR behavior, I think they need test coverage as well.
Is there some kind of special trick to getting the CDR tests to run? I've not actually been able to get any of them to run successfully (they all time out), let alone figure out how to make a new one


File main/cdr.c:

https://gerrit.asterisk.org/c/asterisk/+/18603/comment/a0d79fb0_35bec94d 
PS3, Line 4614: 	if (!mod_cfg || !ast_test_flag(&mod_cfg->general->settings, CDR_IGNORE_DIAL_CHANGES)) {
> The CDR functionality allows reload. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18603
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I393981af42732ec5ac3ff9266444abb453b7c832
Gerrit-Change-Number: 18603
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Sat, 06 Aug 2022 18:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220806/68fd2339/attachment.html>