[Asterisk-code-review] res_hiredis: REDIS DeviceState and Dialplan functions (asterisk[master])

[Joshua Colp]

Attention is currently required from: Sean Bright, N A, Alec Davis.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: res_hiredis: REDIS DeviceState and Dialplan functions
......................................................................


Patch Set 22:

(2 comments)

File res/res_hiredis.c:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/c7396397_6bc134e4 
PS20, Line 919: 	device_state_sub = stasis_subscribe(ast_device_state_topic_all(), device_state_cb, NULL);
If this fails then this isn't going to work, and will confuse.


File res/res_hiredis.c:

https://gerrit.asterisk.org/c/asterisk/+/18829/comment/31a4420c_606e20db 
PS22, Line 854: 	return -1;
> I think the module should be able to be unloaded, this creates a poor user experience
Supporting unload would be an improvement, and likely require some rearchitecture of this module. Not supporting unload is realistically not a huge impact to users. It may be to you, but it's not over all. I won't hold lack of unload support as a blocker for this.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 22
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alec Davis <alec at bdt.co.nz>
Gerrit-Comment-Date: Thu, 04 Aug 2022 13:24:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220804/3c6d814d/attachment-0001.html>