[Asterisk-code-review] general: Very minor formatting improvements. (asterisk[master])

N A asteriskteam at digium.com
Tue Aug 2 20:22:12 CDT 2022


Attention is currently required from: Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18885 )

Change subject: general: Very minor formatting improvements.
......................................................................


Patch Set 2:

(1 comment)

File channels/iax2/include/iax2.h:

https://gerrit.asterisk.org/c/asterisk/+/18885/comment/c917eb76_320fcec2 
PS2, Line 131: #define IAX_IE_CALLED_NUMBER			1		/*!< Number/extension being called - string */
> Tabs need to expand to 4 spaces not 8 spaces. […]
Okay, I see what you're seeing now, I think, which is definitely kind off. If you look at the file on GitHub, or in a text editor locally, the alignment is definitely off there. It seems though like this might stem from using both spacing and tabs, so maybe converting it all to tabs would address that?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18885
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I07771c4c89facd41ce8d323859f022ddbddf6ca7
Gerrit-Change-Number: 18885
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 03 Aug 2022 01:22:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220802/89af079e/attachment.html>


More information about the asterisk-code-review mailing list