[Asterisk-code-review] manager: Remove documentation for nonexistent action. (asterisk[16])

George Joseph asteriskteam at digium.com
Tue Aug 2 09:09:06 CDT 2022


George Joseph has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/18921 )

Change subject: manager: Remove documentation for nonexistent action.
......................................................................

manager: Remove documentation for nonexistent action.

The manager XML documentation documents a "FilterList"
action, but there is no such action. Therefore, this can
lead to confusion when people try to use a documented
action that does not, in fact, exist. This is removed
as the action never did exist in the past, nor would it
be trivial to add since we only store the regex_t
objects, so the filter list can't actually be provided
without storing that separately. Most likely, the
documentation was originally added (around version 10)
in anticipation of something that never happened.

ASTERISK-29917 #close

Change-Id: I846b16fd6f80a91d4ddc5d8a861b522d7c6f8f97
---
M main/manager.c
1 file changed, 0 insertions(+), 15 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved; Approved for Submit



diff --git a/main/manager.c b/main/manager.c
index d793e08..4ea3d97 100644
--- a/main/manager.c
+++ b/main/manager.c
@@ -1283,21 +1283,6 @@
 			this command can be used to create filters that may bypass
 			filters defined in manager.conf</para>
 		</description>
-		<see-also>
-			<ref type="manager">FilterList</ref>
-		</see-also>
-	</manager>
-	<manager name="FilterList" language="en_US">
-		<synopsis>
-			Show current event filters for this session
-		</synopsis>
-		<description>
-			<para>The filters displayed are for the current session.  Only those filters defined in
-                        manager.conf will be present upon starting a new session.</para>
-		</description>
-		<see-also>
-			<ref type="manager">Filter</ref>
-		</see-also>
 	</manager>
 	<manager name="BlindTransfer" language="en_US">
 		<synopsis>

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18921
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I846b16fd6f80a91d4ddc5d8a861b522d7c6f8f97
Gerrit-Change-Number: 18921
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220802/bcbf231f/attachment.html>


More information about the asterisk-code-review mailing list