[Asterisk-code-review] chan_pjsip: Add option to not play music on hold on unanswered channels (asterisk[master])

[George Joseph]

Attention is currently required from: sungtae kim, Sean Bright, N A, Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18781 )

Change subject: chan_pjsip: Add option to not play music on hold on unanswered channels
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

File contrib/ast-db-manage/config/versions/f407f42473e5_add_moh_answeredonly_option_to_pjsip.py:

https://gerrit.asterisk.org/c/asterisk/+/18781/comment/98962aa3_5bfd864a 
PS11, Line 17: YESNO_NAME = 'yesno_values'
             : YESNO_VALUES = ['yes', 'no']
             : 
             : 
Should be using the AST_BOOL stuff.   Look at 2bb1a85135ad_pjsip_add_use_callerid_contact.py as an example.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18781
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3c9b9101e4dc85338154b8004cecdd3edc227474
Gerrit-Change-Number: 18781
Gerrit-PatchSet: 11
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: sungtae kim <pchero21 at gmail.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Tue, 02 Aug 2022 12:33:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220802/cf480e17/attachment.html>