[Asterisk-code-review] Add support for Python 3 (starpy[1.1])

[Michael Bradeen]

Attention is currently required from: Kevin Harwell.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/starpy/+/18244 )

Change subject: Add support for Python 3
......................................................................


Patch Set 3:

(1 comment)

File starpy/manager.py:

https://gerrit.asterisk.org/c/starpy/+/18244/comment/585a30c2_9d253095 
PS2, Line 734:         nowait -- make the origination asynchronous
> I think "nowait" works okay, but what about just "nosync" to keep the naming slightly closer to the  […]
Might have to fight George for the naming rights.  I am going to re-evaluate this and your comments in the testsuite review to come up with the least impactful way to change.



-- 
To view, visit https://gerrit.asterisk.org/c/starpy/+/18244
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: starpy
Gerrit-Branch: 1.1
Gerrit-Change-Id: I2fab42abb5318a5db2af3bcd291fc2db95b87e15
Gerrit-Change-Number: 18244
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 21:46:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220428/d7f512ae/attachment.html>