[Asterisk-code-review] features: Add transfer initiation options. (asterisk[master])

[Kevin Harwell]

Attention is currently required from: N A, Richard Mudgett.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18001 )

Change subject: features: Add transfer initiation options.
......................................................................


Patch Set 4:

(2 comments)

File main/features_config.c:

https://gerrit.asterisk.org/c/asterisk/+/18001/comment/68b93189_7e6675ae 
PS4, Line 915: 		ast_string_field_set(xfer, transferannouncesound, value);
ast_string_field_init_extended(&cfg_info, transferannouncesound); will be needed here for other branches (see Richard's comment).


https://gerrit.asterisk.org/c/asterisk/+/18001/comment/3a18f751_931de3f0 
PS4, Line 1807: 	aco_option_register_custom(&cfg_info, "transferannouncesound", ACO_EXACT, global_options,
> Only for released branches where extended string fields are necessary to avoid ABI breakage.
I have no idea why my initial code comment is here. It should have been above (hopefully marked in correct location now).

Note, Richard's comment still stands too.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18001
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ibff309caa459a2b958706f2ed0ca393b1ef502e3
Gerrit-Change-Number: 18001
Gerrit-PatchSet: 4
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 28 Apr 2022 18:40:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220428/059d78ff/attachment-0001.html>