[Asterisk-code-review] res_ari_channels/res_pjsip: Added test for exposed protocol_id (testsuite[master])

Michael Bradeen asteriskteam at digium.com
Thu Apr 28 12:05:16 CDT 2022


Attention is currently required from: Moritz Fain.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18418 )

Change subject: res_ari_channels/res_pjsip: Added test for exposed protocol_id
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Patchset:

PS1: 
Just regarding the Makefile, I believe this should be handled separately.


File addons/Makefile:

https://gerrit.asterisk.org/c/testsuite/+/18418/comment/165ef621_8c973198 
PS1, Line 34: 		if [ `git config --get remote.origin.url` = https://github.com/asterisk/starpy ]; then \
If there is an issue with the addons Makefile, this should be it's own issue



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18418
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Ibc8a103b9e54d709aa39472fa2d77a969c1685ac
Gerrit-Change-Number: 18418
Gerrit-PatchSet: 1
Gerrit-Owner: Moritz Fain <moritz at fain.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Moritz Fain <moritz at fain.io>
Gerrit-Comment-Date: Thu, 28 Apr 2022 17:05:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220428/507e3f71/attachment.html>


More information about the asterisk-code-review mailing list