[Asterisk-code-review] ari: expose channel driver's unique id to ARI channel resource (asterisk[master])

[Sean Bright]

Attention is currently required from: Joshua Colp, Kevin Harwell, Moritz Fain, Richard Mudgett.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18413 )

Change subject: ari: expose channel driver's unique id to ARI channel resource
......................................................................


Patch Set 9:

(2 comments)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/18413/comment/16d8eb45_9e4acf77 
PS6, Line 1277: 	if (!channel || !uniqueid) {
> Yes, chan_pjsip_new is calling ast_channel_alloc_with_endpoint which is calling channel_snapshot_bas […]
Done


File main/channel_internal_api.c:

https://gerrit.asterisk.org/c/asterisk/+/18413/comment/1c0f0460_c7f2a215 
PS7, Line 587: void ast_channel_tech_pvt_set(struct ast_channel *chan, void *value)
> As discussed with @Kevin Harwell I moved the snapshot BASE segment invalidation to this function.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7cc6e7a9d29efe74bc27811d788dac20fe559b87
Gerrit-Change-Number: 18413
Gerrit-PatchSet: 9
Gerrit-Owner: Moritz Fain <moritz at fain.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Moritz Fain <moritz at fain.io>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 27 Apr 2022 14:47:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Moritz Fain <moritz at fain.io>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220427/fc73cd32/attachment-0001.html>