[Asterisk-code-review] ARI channels: exposed channel driver's unique id (which is the Call-I... (asterisk[master])

[Joshua Colp]

Attention is currently required from: Kevin Harwell, Moritz Fain, Richard Mudgett.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18413 )

Change subject: ARI channels: exposed channel driver's unique id (which is the Call-ID for SIP/PJSIP) to ARI channel resource as 'pvt_id'
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

File main/stasis_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/18413/comment/90e454d9_a25ba46e 
PS6, Line 1282: 		"pvt_id", snapshot->base->pvt_uniqueid,
> Fine as well... […]
I'd prefer protocol_id, because then if another channel driver comes along that actually does implement it then it's a generic reference instead of call_id which is more of a SIP term and may not strictly apply within the context of the other channel driver - or would be named incorrectly.

I know that it is already exposed there, and such things in dialplan are more forgiving. For ARI there should be a conscious effort to not expose internal implementation details/naming as much as possible, and to make it as approachable to non-C Asterisk developers as possible.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7cc6e7a9d29efe74bc27811d788dac20fe559b87
Gerrit-Change-Number: 18413
Gerrit-PatchSet: 6
Gerrit-Owner: Moritz Fain <moritz at fain.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Moritz Fain <moritz at fain.io>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 27 Apr 2022 12:33:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Moritz Fain <moritz at fain.io>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220427/1751e868/attachment-0001.html>