[Asterisk-code-review] ARI channels: exposed channel driver's unique id (which is the Call-I... (asterisk[master])

[Moritz Fain]

Attention is currently required from: Kevin Harwell, Moritz Fain, Richard Mudgett.
Moritz Fain has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18413 )

Change subject: ARI channels: exposed channel driver's unique id (which is the Call-ID for SIP/PJSIP) to ARI channel resource as 'pvt_id'
......................................................................


Patch Set 6:

(2 comments)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/18413/comment/dd955516_bdacdd05 
PS6, Line 575: 	ast_channel_snapshot_invalidate_segment(chan, AST_CHANNEL_SNAPSHOT_INVALIDATE_BASE);
> I first put "ast_channel_snapshot_invalidate_segment" at the bottom of "begin_dial_prerun" (in dial. […]
Ack


File tests/test_stasis_channels.c:

https://gerrit.asterisk.org/c/asterisk/+/18413/comment/b8ea0a84_7e4be84a 
PS6, Line 287: 				 "pvt_id", ast_channel_uniqueid(chan),
> If it's changed to default to an empty string (see previous comment) the test will also need updatin […]
Ack



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18413
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7cc6e7a9d29efe74bc27811d788dac20fe559b87
Gerrit-Change-Number: 18413
Gerrit-PatchSet: 6
Gerrit-Owner: Moritz Fain <moritz at fain.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Moritz Fain <moritz at fain.io>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 27 Apr 2022 12:10:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Moritz Fain <moritz at fain.io>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220427/53acbc10/attachment.html>