[Asterisk-code-review] res_pjsip: Always set async_operations to 1. (asterisk[16])

George Joseph asteriskteam at digium.com
Tue Apr 26 10:10:23 CDT 2022


Attention is currently required from: Joshua Colp, Richard Mudgett.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18365 )

Change subject: res_pjsip: Always set async_operations to 1.
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

File res/res_pjsip/config_transport.c:

https://gerrit.asterisk.org/c/asterisk/+/18365/comment/1eddf2eb_a01a5233 
PS1, Line 493: 		ast_log(LOG_NOTICE, "The async_operations setting on transport '%s' has been set to '%d', this setting can no longer be set and is always 1\n",
> I don't know if we'll remove this, because removing options results in anyone who hasn't removed it  […]
Done


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18365/comment/162bb7d9_5226cd8b 
PS1, Line 1301: 					<synopsis>Number of simultaneous Asynchronous Operations, can no longer be set, always set to 1</synopsis>
> May want to indicate that the option should be removed in the future.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18365
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I1915973ef352862dc2852a6ba4cfce2ed536e68f
Gerrit-Change-Number: 18365
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 26 Apr 2022 15:10:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220426/c0693a08/attachment.html>


More information about the asterisk-code-review mailing list