[Asterisk-code-review] core_unreal & app_dial: Flip stream direction of second channel. (asterisk[16])

[Maximilian Fridrich]

Attention is currently required from: Florian Floimair, Joshua Colp.
Maximilian Fridrich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18371 )

Change subject: core_unreal & app_dial: Flip stream direction of second channel.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS2: 
> Yes, the case where local channels are in between the two channels was not accounted for, sorry abou […]
I have tested patchset 3 with local and non-local channels (both optimized and non-optimized) and with multiple local channels in between.

The source of the issue was that in ast_unreal_new_channels the topology of the first unreal (local) channel was cloned and used for its counterpart (basically identical to the issue in app_dial).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18371
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I294dc834ac9a5f048b101b691669959e9df630e1
Gerrit-Change-Number: 18371
Gerrit-PatchSet: 3
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Florian Floimair <f.floimair at commend.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 11:44:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Florian Floimair <f.floimair at commend.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220421/b00163e1/attachment.html>