[Asterisk-code-review] app_dial: Flip stream direction of outgoing channel. (asterisk[16])

[Florian Floimair]

Attention is currently required from: Maximilian Fridrich.
Florian Floimair has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18371 )

Change subject: app_dial: Flip stream direction of outgoing channel.
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> Since we moved this to app_dial we have some side-effects (media direction flipped for video during  […]
Our current hypothesis is:
Since we use Local channels in our dialplan, we do the flip twice when the code is in app_dial (since there is a Dial to the local channel followed by a dial to PJSIP in within the local channel's context in the dialplan). Once the call is established and the local channel optimized out the direction is then correct.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18371
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I294dc834ac9a5f048b101b691669959e9df630e1
Gerrit-Change-Number: 18371
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Wed, 20 Apr 2022 13:28:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Florian Floimair <f.floimair at commend.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220420/8046e349/attachment.html>