[Asterisk-code-review] res_pjsip_header_funcs: Add functions PJSIP_REPLY_HEADER and PJSIP_RE... (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, José Lopes.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18367 )

Change subject: res_pjsip_header_funcs: Add functions PJSIP_REPLY_HEADER and PJSIP_REPLY_HEADERS
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/d3f187e3_16a842e2 
PS3, Line 7: res_pjsip_header_funcs: Add functions PJSIP_REPLY_HEADER and PJSIP_REPLY_HEADERS
In SIP this is called a response, not a reply. I think it should be renamed to be consistent with that SIP term.


Patchset:

PS3: 
This also needs a CHANGES entry[1].

[1] https://wiki.asterisk.org/wiki/display/AST/CHANGES+and+UPGRADE.txt


File res/res_pjsip_reply_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/b91076ad_21dae230 
PS3, Line 111: 			INVITE reply message. Multiple headers with the same name are included in the list only once.
What happens if there are multiple responses? The behavior should be documented


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/eefc8c90_10348ef5 
PS3, Line 138: /*! \brief Data structure used for ast_sip_push_task_wait_serializer  */
This duplicates a lot of the code from res_pjsip_header_funcs, I think it should just be part of that module.


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/99fed8eb_f610a9c2 
PS3, Line 184: 	if (session->inv_session->state <= PJSIP_INV_STATE_EARLY) {
Document why PJSIP_INV_STATE_EARLY



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18367
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I264a610a9333359297a0825feb29a1bb4f4ad144
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 3
Gerrit-Owner: José Lopes <jose.lopes at nfon.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: José Lopes <jose.lopes at nfon.com>
Gerrit-Comment-Date: Wed, 20 Apr 2022 12:52:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220420/d369cba5/attachment.html>