[Asterisk-code-review] config.h: Don't use C++ keywords as argument names. (asterisk[16])

N A asteriskteam at digium.com
Tue Apr 19 11:25:33 CDT 2022


Attention is currently required from: Sean Bright.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18408 )

Change subject: config.h: Don't use C++ keywords as argument names.
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
I might be missing something, but is there a reason you're only updating config.h, not config.c?

https://github.com/asterisk/asterisk/blob/b40c4d59b1dd803cad79060fb5b5a48d249ba578/main/config.c#L682

int ast_variable_list_replace_variable(struct ast_variable **head, struct ast_variable *old,
	struct ast_variable *new)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18408
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I70eb59b782a4946b979942e21422746b7563029c
Gerrit-Change-Number: 18408
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 16:25:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220419/b5ba9a2a/attachment-0001.html>


More information about the asterisk-code-review mailing list