[Asterisk-code-review] res_geolocation: Add initial markdown for Geolocation wiki pages (asterisk[development/16/geolocation])

George Joseph asteriskteam at digium.com
Tue Apr 19 07:15:31 CDT 2022


Attention is currently required from: Joshua Colp, Kevin Harwell.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18360 )

Change subject: res_geolocation:  Add initial markdown for Geolocation wiki pages
......................................................................


Patch Set 1:

(8 comments)

File res/res_geolocation/wiki/AsteriskImplementation.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/c76ab2bf_8fd4ca49 
PS1, Line 80: pof
> pof?
Done


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/b21128f6_4db951de 
PS1, Line 80: Any parameter than can use channel variables can also arbitrary variables defined in this paramete
> s/than/that? […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/7d6ba764_c570d429 
PS1, Line 101: descibes
> s/descibes/describes
Done


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/dcc9f863_c8d7b010 
PS1, Line 133: this..
> extra period here?

No.  Not enough periods. 😊


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/b33926a5_093ded84 
PS1, Line 144: would exactly
> would be exactly
Done


File res/res_geolocation/wiki/CivicAddress.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/8e02b189_0937598c 
PS1, Line 58: descibes
> s/descibes/describes
Done


File res/res_geolocation/wiki/Geolocation.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/c63f0256_6c88b573 
PS1, Line 2: inplmented
> s/inplmented/implemented
Done


File res/res_geolocation/wiki/LocationConcepts.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/d3aeac1e_44fdfd36 
PS1, Line 14: locatons
> s/locatons/locations
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18360
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: I85b239776209bff3fc3388cf9b0a322a1764db29
Gerrit-Change-Number: 18360
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 12:15:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220419/85d78b18/attachment.html>


More information about the asterisk-code-review mailing list