[Asterisk-code-review] res_pjsip_session: Flip stream direction of outgoing stream. (asterisk[16])

[Joshua Colp]

Attention is currently required from: Maximilian Fridrich.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18371 )

Change subject: res_pjsip_session: Flip stream direction of outgoing stream.
......................................................................


Patch Set 1:

(1 comment)

File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18371/comment/cb3ff1bd_bf942a80 
PS1, Line 3425: 			if (ast_stream_get_state(req_stream) == AST_STREAM_STATE_SENDONLY) {
> I see what you're saying and the bridge definitely seems like the right place for this reversal of s […]
Yes, I believe it should be further up - that is the responsibility for determining the proper stream state should be what ultimately requests/passes it to the core. The channel driver (in this case PJSIP) should just do as it is told, because it doesn't know whether it should or should not flip it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18371
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I294dc834ac9a5f048b101b691669959e9df630e1
Gerrit-Change-Number: 18371
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Florian Floimair <f.floimair at commend.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Thu, 14 Apr 2022 09:49:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220414/c2502731/attachment-0001.html>