[Asterisk-code-review] res_pjsip_session: Flip stream direction of outgoing stream. (asterisk[16])

[Maximilian Fridrich]

Attention is currently required from: Joshua Colp.
Maximilian Fridrich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18371 )

Change subject: res_pjsip_session: Flip stream direction of outgoing stream.
......................................................................


Patch Set 1:

(1 comment)

File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18371/comment/5030db01_ca864e45 
PS1, Line 3425: 			if (ast_stream_get_state(req_stream) == AST_STREAM_STATE_SENDONLY) {
> This needs a comment here explaining what is happening, why, and the result on the SDP itself.
Before I keep adding tiny commits - would this be sufficient or do you want me to elaborate a bit more?

/* The state of the outgoing stream needs to be opposite of the incoming stream.
 * This ensures that the local SDP is correctly set when we receive an SDP answer
 * from the second call leg and SDP negotiation returns the expected stream state.
 */



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18371
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I294dc834ac9a5f048b101b691669959e9df630e1
Gerrit-Change-Number: 18371
Gerrit-PatchSet: 1
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 13:53:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220413/6a590ac4/attachment.html>