[Asterisk-code-review] res_geolocation: Add initial markdown for Geolocation wiki pages (asterisk[development/16/geolocation])

George Joseph asteriskteam at digium.com
Wed Apr 13 06:41:55 CDT 2022


Attention is currently required from: Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18360 )

Change subject: res_geolocation:  Add initial markdown for Geolocation wiki pages
......................................................................


Patch Set 1:

(2 comments)

File res/res_geolocation/wiki/AsteriskImplementation.md:

https://gerrit.asterisk.org/c/asterisk/+/18360/comment/b030ac94_1134c17a 
PS1, Line 87: |geoloc_outgoing_call_profile|Should be set to the name of a geolocation profile to use for calls Asterisk sends to this remote endpoint.  If not set, no geolocation processing will occur and any location descriptions coming from the associated incoming channel or the dialplan will be silently dropped.|
> I think adding "and not conveyed to the endpoint" would be a bit more explicit.
Done


https://gerrit.asterisk.org/c/asterisk/+/18360/comment/71012eed_715dc692 
PS1, Line 90: Two new dialplan applications and one dialplan function have been adedd to allow a dialplan author to manipulate 
> added instead of adedd, and redness
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18360
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: development/16/geolocation
Gerrit-Change-Id: I85b239776209bff3fc3388cf9b0a322a1764db29
Gerrit-Change-Number: 18360
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 13 Apr 2022 11:41:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220413/94b8bf34/attachment.html>


More information about the asterisk-code-review mailing list