[Asterisk-code-review] core_local: Fix local channel parsing with slashes (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Richard Mudgett.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18369 )

Change subject: core_local: Fix local channel parsing with slashes
......................................................................


Patch Set 3:

(1 comment)

File main/core_local.c:

https://gerrit.asterisk.org/c/asterisk/+/18369/comment/f9a7ce07_9037ae9e 
PS3, Line 907: 	if ((opts = strrchr(parse, '/')) && really_local_options(opts)) {
> Sorry, currently, what I typically do is stuff like: […]
Hmm... that seems like an elegant possible solution (to be sure, might look a bit funny in the dialplan, but eh, whatever). Let me pursue that and I'll update the review this week.

Additionally, just to make it look "better", maybe we could add a Local option that does nothing at all? And then do something like:

Originate(Local/PJSIP/device/x)

where x does nothing and is simply to prevent someone else from coming in and thinking you made a typo. At least, as such it could be documented in that manner so people know that the trailing slash is required or it would change functionality.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18369
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8e85bc14072e452d0537a801aba17779569d0360
Gerrit-Change-Number: 18369
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 12:06:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220412/93e0cfca/attachment.html>