[Asterisk-code-review] core_local: Fix local channel parsing with slashes (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Richard Mudgett.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18369 )

Change subject: core_local: Fix local channel parsing with slashes
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File main/core_local.c:

https://gerrit.asterisk.org/c/asterisk/+/18369/comment/88620d26_1deaa090 
PS3, Line 317: 		if (*ptr != '/' && *ptr != 'n' && *ptr != 'j' && *ptr != 'm' && *ptr != 'b') {
This feels brittle.


https://gerrit.asterisk.org/c/asterisk/+/18369/comment/51ed9832_0bce0c26 
PS3, Line 907: 	if ((opts = strrchr(parse, '/')) && really_local_options(opts)) {
What are the various formats you are supporting here (with any without options), so it can be seen if there is a better way.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18369
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I8e85bc14072e452d0537a801aba17779569d0360
Gerrit-Change-Number: 18369
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 12 Apr 2022 10:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220412/fdb1b802/attachment.html>