[Asterisk-code-review] chan_pjsip.c: allow_180_ringing_with_sdp (asterisk[16])

[Mark Petersen]

Attention is currently required from: Joshua Colp, N A, Alexei Gradinari, Mark Petersen.
Mark Petersen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17785 )

Change subject: chan_pjsip.c: allow_180_ringing_with_sdp
......................................................................


Patch Set 14:

(1 comment)

File channels/chan_pjsip.c:

https://gerrit.asterisk.org/c/asterisk/+/17785/comment/bbb01cbf_4ee76035 
PS5, Line 1625: 				response_code = 183;
> Right, within the core there is no differentiation really.
this patch only solve the issue with receiving 180 without SDP after an 183
so I guess I should create a new Jira with regards to handling 183 without and 180 with SDP, and hope that we can look at that issue at the next AstriDevCon for Asterisk 21
so the only issue I believe is left is should I change the text to reflect that it is only 180 without SDP that will be affected



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17785
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I8a53f8c35595b6d16d8e86e241b5f110d92f3d18
Gerrit-Change-Number: 17785
Gerrit-PatchSet: 14
Gerrit-Owner: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-CC: Mark Petersen <asterisk.org at zombie.dk>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Mark Petersen <bugs.digium.com at zombie.dk>
Gerrit-Comment-Date: Mon, 11 Apr 2022 18:32:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Mark Petersen <bugs.digium.com at zombie.dk>
Comment-In-Reply-To: Mark Petersen <asterisk.org at zombie.dk>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220411/c47cfc23/attachment.html>