[Asterisk-code-review] app_meetme: Emit warning if conference not found. (asterisk[18])

Joshua Colp asteriskteam at digium.com
Fri Apr 8 11:31:02 CDT 2022


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/18344 )

Change subject: app_meetme: Emit warning if conference not found.
......................................................................

app_meetme: Emit warning if conference not found.

Currently, if a user tries to access a non-dynamic
MeetMe conference and the conference is not found,
the call simply silent hangs up. There is no indication
to the user that anything went wrong at all.

This changes the relevant debug message to a warning
so that the user is notified of this invalidity.

ASTERISK-29954 #close

Change-Id: Iebcfae3755d00f2150d676ee211c57bc59530048
---
M apps/app_meetme.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  Benjamin Keith Ford: Looks good to me, approved



diff --git a/apps/app_meetme.c b/apps/app_meetme.c
index 99a824d..e7ade64 100644
--- a/apps/app_meetme.c
+++ b/apps/app_meetme.c
@@ -4761,7 +4761,7 @@
 				}
 			}
 			if (!var) {
-				ast_debug(1, "%s isn't a valid conference\n", confno);
+				ast_log(LOG_WARNING, "%s isn't a valid conference\n", confno);
 			}
 			ast_config_destroy(cfg);
 		}

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18344
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Iebcfae3755d00f2150d676ee211c57bc59530048
Gerrit-Change-Number: 18344
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220408/417d7409/attachment.html>


More information about the asterisk-code-review mailing list