[Asterisk-code-review] res_pjsip: Add functions PJSIP_REPLY_HEADER and PJSIP_REPLY_HEADERS (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, José Lopes.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18367 )

Change subject: res_pjsip: Add functions PJSIP_REPLY_HEADER and PJSIP_REPLY_HEADERS
......................................................................


Patch Set 1: Code-Review-1

(6 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/adce6682_7f8aa472 
PS1, Line 7: res_pjsip: Add functions PJSIP_REPLY_HEADER and PJSIP_REPLY_HEADERS
This isn't res_pjsip, this is res_pjsip_header_funcs.


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/7457e686_6eb079ac 
PS1, Line 9: These new functions allows to retrieve information from Headers on 200 OK
allow retrieving


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/c3729251_fce353f4 
PS1, Line 11: This code is based on res_pjsip_header_funcs.c .
You should wrap your commit message at 72 chars.
Additionally, it's not necessary to reference res_pjsip_header_funcs.c.


File res/res_pjsip_reply_header_funcs.c:

https://gerrit.asterisk.org/c/asterisk/+/18367/comment/7c17620d_43aa9991 
PS1, Line 7:  *
Your information should go in here. Update the copyright, year, and author.
You can use another file as a template but this is wrong.


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/fe18809b_c423a46d 
PS1, Line 49: 					may be appended to <replaceable>name</replaceable> to iterate over all 
redness


https://gerrit.asterisk.org/c/asterisk/+/18367/comment/43ef2d1c_41c7cadf 
PS1, Line 67: 			PJSIP channel.</para>
Use the example XML tag instead of a bunch of para tags.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18367
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I264a610a9333359297a0825feb29a1bb4f4ad144
Gerrit-Change-Number: 18367
Gerrit-PatchSet: 1
Gerrit-Owner: José Lopes <jose.lopes at nfon.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: José Lopes <jose.lopes at nfon.com>
Gerrit-Comment-Date: Fri, 08 Apr 2022 14:29:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220408/9498aa26/attachment.html>