[Asterisk-code-review] res_calendar: Prevent assertion if event ends in past. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18250 )

Change subject: res_calendar: Prevent assertion if event ends in past.
......................................................................


Patch Set 2:

(1 comment)

File res/res_calendar.c:

https://gerrit.asterisk.org/c/asterisk/+/18250/comment/3ea811b8_6711d977 
PS2, Line 1002: 		if (devstate_sched_end <= 0) { /* if we let this slip by, Asterisk will assert */
> Should this even replace in this scenario? Should it just unschedule?
To answer your question, I'm not sure personally and wouldn't be qualified to say one way or another.
If you're saying that would be the more sensible thing to do, I can make that change. That's just what all the other branches do currently.
Otherwise, we can wait for somebody else to chime in.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18250
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Idfb3204d195f350d2575fb4bc72a54a597d6e93c
Gerrit-Change-Number: 18250
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 01 Apr 2022 20:35:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220401/b106a181/attachment.html>