[Asterisk-code-review] res_pjsip_t38: bind UDPTL sessions like RTP (asterisk[16])

Kevin Harwell asteriskteam at digium.com
Thu Sep 30 16:14:17 CDT 2021


Attention is currently required from: Matthew Kern.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16546 )

Change subject: res_pjsip_t38: bind UDPTL sessions like RTP
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2: 
Not exactly sure at the moment, but the two testsuite tests that failed across all builds:

tests/rest_api/asterisk/config/dynamic/update
tests/rest_api/asterisk/config/dynamic/pjsip/modify_endpoint

do seem like legitimate failures when this patch is applied. I confirmed this locally as well.

-1 for now until things can be further investigated.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16546
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I87220c0e9cdd2fe9d156846cb906debe08c63557
Gerrit-Change-Number: 16546
Gerrit-PatchSet: 2
Gerrit-Owner: Matthew Kern <mkern at alconconstruction.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Joe <ynadiv at corpit.xyz>
Gerrit-Attention: Matthew Kern <mkern at alconconstruction.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 21:14:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210930/62388245/attachment.html>


More information about the asterisk-code-review mailing list