[Asterisk-code-review] apps/app_playback.c: Add 'mix' option to app_playback (asterisk[16])

Shloime Rosenblum asteriskteam at digium.com
Thu Sep 30 14:28:08 CDT 2021


Shloime Rosenblum has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16540 )

Change subject: apps/app_playback.c: Add 'mix' option to app_playback
......................................................................


Patch Set 6:

(1 comment)

File apps/app_playback.c:

https://gerrit.asterisk.org/c/asterisk/+/16540/comment/8fb0505c_4279977d 
PS3, Line 55: 				<para>List of options (You can do Playback(filename,skipmix) or Playback(filename,mix|skip) but you can't use a comma as a delimeter).</para>
> I understand but i am saying that it is is probably used in a lot of dialplans because there is info […]
I didn't change in any way how the options are delimited i just changed the documentation based on what @InterLinked said but after testing with a comma i removed that change



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16540
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a
Gerrit-Change-Number: 16540
Gerrit-PatchSet: 6
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 19:28:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Shloime Rosenblum <shloimerosenblum at gmail.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210930/d7a80db0/attachment-0001.html>


More information about the asterisk-code-review mailing list