[Asterisk-code-review] app_read: Fix null pointer crash (asterisk[16])

[Joshua Colp]

Attention is currently required from: Sean Bright, N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16548 )

Change subject: app_read: Fix null pointer crash
......................................................................


Patch Set 5:

(1 comment)

File apps/app_read.c:

https://gerrit.asterisk.org/c/asterisk/+/16548/comment/ce255597_3198fa50 
PS4, Line 253: 					if (terminator && strchr(terminator, tmp[x-1])) {
> Fixed. […]
To be honest unless it's you, the chances of anyone ever touching this code ever again is slim to none. If you want to add a comment on the definition of terminator and here expressing that it should never be NULL because that's the contract, then that's fine.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16548
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie941833e123c3dbfb88371b5de5edbbe065514ac
Gerrit-Change-Number: 16548
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 11:38:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210930/43899a25/attachment.html>