[Asterisk-code-review] apps/app_playback.c: Add 'mix' option to app_playback (asterisk[16])

[Shloime Rosenblum]

Attention is currently required from: Sean Bright, N A, Kevin Harwell.
Shloime Rosenblum has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16540 )

Change subject: apps/app_playback.c: Add 'mix' option to app_playback
......................................................................


Patch Set 4:

(3 comments)

File apps/app_playback.c:

https://gerrit.asterisk.org/c/asterisk/+/16540/comment/83e1a36d_f746fa25 
PS3, Line 55: 				<para>List of options (You can do Playback(filename,skipmix) or Playback(filename,mix|skip) but you can't use a comma as a delimeter).</para>
> > The other option is to make this a master only patch. […]
The say option is documented here and is very likely used in a lot of dialplans https://www.voip-info.org/asterisk-cmd-playback/

Also i tested playback and it does work with a comma as the delimiter


https://gerrit.asterisk.org/c/asterisk/+/16540/comment/1585a7ba_06d02944 
PS3, Line 498: 			else if (option_mix){
> add a space between closing ')' and '{'
Done


https://gerrit.asterisk.org/c/asterisk/+/16540/comment/1b6573eb_99f33091 
PS3, Line 500: 				if (strcasestr(front, ":") && !strcasestr(front, "://"))
             : 					res = say_full(chan, front, "", ast_channel_language(chan), NULL, -1, -1);
             : 				else
             : 					res = ast_streamfile(chan, front, ast_channel_language(chan));
> You could combine this with the "else if" above and then drop the associated else if you wanted. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16540
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a
Gerrit-Change-Number: 16540
Gerrit-PatchSet: 4
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 02:37:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210929/ced49bb8/attachment.html>