[Asterisk-code-review] res_pjsip_t38: bind UDPTL sessions like RTP (asterisk[16])

[Matthew Kern]

Attention is currently required from: George Joseph.
Matthew Kern has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16546 )

Change subject: res_pjsip_t38: bind UDPTL sessions like RTP
......................................................................


Patch Set 2:

(3 comments)

Patchset:

PS2: 
Okay, I think that's fixed. Thanks for pointing me to the correct syntax for that alembic script.


File contrib/ast-db-manage/config/versions/a06d8f8462d9_add_t38_bind_udptl_to_media_address.py:

https://gerrit.asterisk.org/c/asterisk/+/16546/comment/a9acd3a3_91d1168a 
PS1, Line 17: YESNO_NAME = 'yesno_values'
            : YESNO_VALUES = ['yes', 'no']
            : 
> It's not documented well but we've changed how boolean values are represented. […]
Done


File doc/CHANGES-staging/res_pjsip_t38_bind_fixes.txt:

https://gerrit.asterisk.org/c/asterisk/+/16546/comment/462aae10_408eb1be 
PS1, Line 1: Use same bind logic from RTP sessions for UDPTL init
> Subject should just be the name of the module.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16546
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I87220c0e9cdd2fe9d156846cb906debe08c63557
Gerrit-Change-Number: 16546
Gerrit-PatchSet: 2
Gerrit-Owner: Matthew Kern <mkern at alconconstruction.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joe <ynadiv at corpit.xyz>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 22:04:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210929/ab6e9146/attachment.html>