[Asterisk-code-review] app_read: Fix null pointer crash (asterisk[master])

N A asteriskteam at digium.com
Wed Sep 29 13:08:13 CDT 2021


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16562 )

Change subject: app_read: Fix null pointer crash
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1: 
> This appears to be a regression introduced by your Read change, currently presently in the release c […]
That's correct. It's triggered by specifying t with no arguments, that is, removing the terminator. So it's not going to affect existing systems, but it would affect somebody using the new option and not providing any arguments. Probably unlikely to be encountered in real scenarios, but I just noticed it and probably best to fix the mistake before the general 18.7 release.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16562
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie941833e123c3dbfb88371b5de5edbbe065514ac
Gerrit-Change-Number: 16562
Gerrit-PatchSet: 1
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-CC: Friendly Automation
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 18:08:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210929/f56445aa/attachment.html>


More information about the asterisk-code-review mailing list