[Asterisk-code-review] main/say.c: Support future dates with Q and q format params (asterisk[master])

[Kevin Harwell]

Attention is currently required from: Sean Bright, Joshua Colp, Shloime Rosenblum.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16517 )

Change subject: main/say.c: Support future dates with Q and q format params
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
Maybe this is good enough as this patch has it (for now at least), but while this patch adds future dates when listening to the actual output there is no way to distinguish between future or past for some values.

For example items that fall within +/- a week it might just output "Wednesday". As the listener I don't know if that was last Wednesday, or next Wednesday.

For some use cases do you see that being a problem? Should future values always output the full datetime? Is there a way to add in "next" or "last" for those relevant time windows?

I don't think it has to hold up this patch. Probably fine as it is now, and something can be added later if necessary. Any thoughts?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16517
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1fb1cef0ce3c18d87b1fc94ea309d13bc344af02
Gerrit-Change-Number: 16517
Gerrit-PatchSet: 2
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Comment-Date: Fri, 24 Sep 2021 17:30:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210924/307b90d2/attachment.html>