[Asterisk-code-review] res_pjsip_t38: bind UDPTL sessions like RTP (asterisk[18])

Matthew Kern asteriskteam at digium.com
Fri Sep 24 12:24:12 CDT 2021


Attention is currently required from: Joshua Colp, Joe.
Matthew Kern has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16156 )

Change subject: res_pjsip_t38: bind UDPTL sessions like RTP
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS1: 
> I just did this and also found it difficult the first time but once you do it once it's not that bad […]
I definitely didn't cherry-pick the master branch correctly, but just doing the cherry-pick to 19 causes that build failure, saying f56d79a9f337 is not present. I assume what I did (re-running the alembic revision -m step and merging the change into the newly-created file) is incorrect, but what is the right thing to do in this case?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16156
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I87220c0e9cdd2fe9d156846cb906debe08c63557
Gerrit-Change-Number: 16156
Gerrit-PatchSet: 4
Gerrit-Owner: Matthew Kern <mkern at alconconstruction.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Joe <ynadiv at corpit.xyz>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joe <ynadiv at corpit.xyz>
Gerrit-Comment-Date: Fri, 24 Sep 2021 17:24:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matthew Kern <mkern at alconconstruction.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210924/e2cb3814/attachment.html>


More information about the asterisk-code-review mailing list