[Asterisk-code-review] apps/app_playback.c: Add 'mix' option to app_playback (asterisk[18])

[Kevin Harwell]

Attention is currently required from: N A, George Joseph, Shloime Rosenblum.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16493 )

Change subject: apps/app_playback.c: Add 'mix' option to app_playback
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4: 
Looks like there is a problem with the XML (not exactly sure what):

11:26:17  xml.parsers.expat.ExpatError: not well-formed (invalid token): line 1844, column 90
11:26:17  make: *** [doc/full-en_US.xml] Error 1

.....

11:26:27  /usr/bin/xmllint --dtdvalid doc/appdocsxml.dtd --noout doc/core-en_US.xml
11:26:27  doc/core-en_US.xml:2053: parser error : EntityRef: expecting ';'
11:26:27  g a mix of filename and the say.conf file (Example: Playback(filename&digit:1234
11:26:27                                                                                 ^
11:26:27  make: *** [validate-docs] Error 1



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16493
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I815816916a308f0fa8f165140dc15772dcbd547a
Gerrit-Change-Number: 16493
Gerrit-PatchSet: 4
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Comment-Date: Thu, 23 Sep 2021 21:27:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210923/74e6d0a4/attachment-0001.html>