[Asterisk-code-review] main/say.c: Support future dates with Q and q format params (asterisk[master])

[Joshua Colp]

Attention is currently required from: Sean Bright, George Joseph, Shloime Rosenblum.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16517 )

Change subject: main/say.c: Support future dates with Q and q format params
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> I can't think of a reason why someone would want to hear today on a date that is not today it would  […]
Let me be more specific. This API is used in such places as voicemail, is there a scenario there which would have previously resulted in today but now would state the future?

The dialplan application is one element of this, but there are other modules using it as well.

That's what I'm asking to ensure that we won't have some unintended behavior change that shouldn't have really happened.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16517
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I1fb1cef0ce3c18d87b1fc94ea309d13bc344af02
Gerrit-Change-Number: 16517
Gerrit-PatchSet: 2
Gerrit-Owner: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-Comment-Date: Thu, 23 Sep 2021 15:59:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Comment-In-Reply-To: Shloime Rosenblum <shloimerosenblum at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210923/2a69be8b/attachment.html>