[Asterisk-code-review] res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts (asterisk[16])

[Kevin Harwell]

Attention is currently required from: Joshua Colp, George Joseph, Joe.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16160 )

Change subject: res_pjsip_registrar: Remove unavailable contacts if exceeds max_contacts
......................................................................


Patch Set 11:

(1 comment)

File res/res_pjsip_registrar.c:

https://gerrit.asterisk.org/c/asterisk/+/16160/comment/b20af59c_bd686e1b 
PS11, Line 736: 			contacts = ast_sip_location_retrieve_aor_contacts_nolock(aor);
              : 			if (!contacts) {
              : 				response->code = 500;
              : 				pjsip_endpt_release_pool(ast_sip_get_pjsip_endpoint(), details.pool);
              : 				return;
              : 			}
> As far the the unref, contacts gets unref'd at the end of this function (keep in mind that contacts already exists here, we're just refreshing it).

Hrm my eyes may be deceiving me, but I'm not seeing it. I see the original container get unref'd in the 'register_aor' function, but not seeing where this newly created contacts container is unref'd.

> A concern I had is what would happen if max_contacts=1 and remove_unavail=yes, then after the (only) contact is removed we'll return a 500.

Sounds like a valid use case and one you might consider adding to your test.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16160
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia2711b08f2b4d1177411b1be23e970d7fdff5784
Gerrit-Change-Number: 16160
Gerrit-PatchSet: 11
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Joe <ynadiv at corpit.xyz>
Gerrit-Comment-Date: Thu, 23 Sep 2021 15:39:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210923/1f16cb18/attachment.html>