[Asterisk-code-review] tests/pjsip/config_options/remove_unavailable: Test new config option (testsuite[master])

[Kevin Harwell]

Attention is currently required from: Joe.
Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/16491 )

Change subject: tests/pjsip/config_options/remove_unavailable: Test new config option
......................................................................


Patch Set 3: -Code-Review

(2 comments)

File tests/channels/pjsip/registration/inbound/nominal/config_options/remove_unavailable/sipp/register-ipv4-remove-existing-enabled.xml:

https://gerrit.asterisk.org/c/testsuite/+/16491/comment/2db40a9d_ed784f72 
PS3, Line 73: 			<ereg regexp="Contact: <sip:(charlie|carol)-2 at 127.0.0.3:5063>;expires=(60|5[5-9])" search_in="msg" check_it="true" assign_to="4"/>
> This one is reachable, only 5062 is unreachable. […]
Ah okay I see now. I was just looking at the address/port and thinking there was no actual endpoint there, thus unreachable, but Asterisk doesn't mark it as such until it tries, and itself knows.


File tests/channels/pjsip/registration/inbound/nominal/config_options/remove_unavailable/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/16491/comment/60699b18_d5b2560b 
PS3, Line 56:                 - { 'key-args': {'scenario': 'register-ipv4-remove-existing-enabled.xml', '-i': '127.0.0.1', '-p': '5161', '-s': 'carol'} }
> I fixed this by changing the port to 5161 here and the error no longer occurs.
oh man ha I swear I looked at that port number and saw 5061. My eyes deceived me :-)



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/16491
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: I336bd2bac512396b33407882066a8ec66a914f5c
Gerrit-Change-Number: 16491
Gerrit-PatchSet: 3
Gerrit-Owner: Joe <ynadiv at corpit.xyz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Joe <ynadiv at corpit.xyz>
Gerrit-Comment-Date: Thu, 23 Sep 2021 15:26:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joe <ynadiv at corpit.xyz>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20210923/7a9bb813/attachment.html>